Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pkg_resources api deprecated warning #2438

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix pkg_resources api deprecated warning #2438

merged 1 commit into from
Dec 13, 2024

Conversation

zhuwenxing
Copy link
Contributor

/kind improvement

@sre-ci-robot
Copy link

@zhuwenxing: The label(s) kind/improvement cannot be applied, because the repository doesn't have them.

In response to this:

/kind improvement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mergify mergify bot added the dco-passed label Dec 12, 2024
@zhuwenxing zhuwenxing force-pushed the fix_pkg_resources_warn branch from 1e31969 to 272f2e3 Compare December 12, 2024 11:32
@mergify mergify bot added the ci-passed label Dec 12, 2024
@zhuwenxing
Copy link
Contributor Author

got warnings when using pymilvus

.venv/lib/python3.12/site-packages/pymilvus/client/__init__.py:6
  /Users/zilliz/workspace/milvus_beir/.venv/lib/python3.12/site-packages/pymilvus/client/__init__.py:6: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    from pkg_resources import DistributionNotFound, get_distribution

this pr is to fix this warning

@zhuwenxing
Copy link
Contributor Author

/assign @XuanYang-cn

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn, zhuwenxing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Dec 13, 2024
@sre-ci-robot sre-ci-robot merged commit 250e7f2 into milvus-io:master Dec 13, 2024
11 checks passed
@djwessel
Copy link

@XuanYang-cn When do we plan for this to find it's way into 2.x? we have now had at least 3 releases of 2.5.x since this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjiquan longjiquan Awaiting requested review from longjiquan

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@XuanYang-cn XuanYang-cn

Labels
approved ci-passed dco-passed lgtm PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhuwenxing @sre-ci-robot @XuanYang-cn @djwessel